Page MenuHome GnuPG
Create Task
Maniphest T5533

Kleopatra: Raise window more agressively on Windows
Closed, ResolvedPublic
Actions

Description

It has been reported and I can reproduce it, too that Kleopatra does not pop up in the foreground correctly when it does not have the AllowForegroundWindow permission. This can happen regularly. For pinentry this was a long standing issue that the passphrase dialog was in the background. We have an elegant solution for that with the logic from Pinentry with:
https://dev.gnupg.org/T4123

I hope that we can apply this somewhere centrally in Kleopatra.

This is important because it confuses especially new users who would not recognize a blinking Kleopatra icon in the task bar.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRAfba38b9d27d8 W32: Change window behavior to always activate

Related Objects

Event Timeline

• aheinecke triaged this task as High priority.Jul 28 2021, 6:43 PM
• aheinecke created this task.
• aheinecke added a comment.Aug 4 2021, 3:20 PM

I am pretty sure that an AllowSetForegroundWindow in the kuniqueservice_win implementation in Kleopatra will alleviate this issue. Since we pass a double click on a file which has foreground window permissions to the existing process which at this point may not have foreground window permissions. If this still does not help we can do the minimize / maximize trick.

• aheinecke added a commit: rKLEOPATRAfba38b9d27d8: W32: Change window behavior to always activate.Aug 4 2021, 4:08 PM
• aheinecke changed the task status from Open to Testing.Aug 4 2021, 4:09 PM

AllowSetForegroundWindow did not work but the code from pinentry works even without the minimize / raise. The minimize raise is only required for the proper input focus and a nice animation for pinentry but the QWindowsWindowBehavior is already sufficient.

• aheinecke mentioned this in T5780: Kleopatra: Result dialog does not have focus after operation.Jan 14 2022, 10:25 AM
• aheinecke closed this task as Resolved.Aug 15 2022, 2:28 PM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 24 2023, 2:12 PM
OSZAR »